Migration of button-pressed and button-released to new GtkGesture API. #16919
Conversation
|
It would be awesome if anyone can set the label to gtk4, cause I can't. Thanks in advance. Greetings |
|
I got a short question: As I wrote in the introduction of this pr, I got a lot of additional changes if the first change here is fine for everyone. Just because of the implementation style. Now should I open a separate pr when this one has been accepted or should I keep on pushing to this pr branch with all further changes and tell here when I am ready? I got a lot of changes in the pipeline with the new GtkGesture API. :-) Thanks in advance. |
It all depends, I do prefer separate PR for separate issues and it gets easier to review. But seems like the other changes are GtkGesture related I would push on this same PR on separate commits to ease the incremental review. I would then merge this when accepted by squashing together all changes in a given PR. Hopefully we would be able to start reviewing and integrating those changes after 4.8 is released. Hope this plan is ok to you. |
|
After more discussion with the dev having worked on the Gtk+ code base it seems preferable to have a dedicated branch for all the Gtk4 code migration. So I have changed my mind and I'd like to go this path. A single PR with all commits for the Gtk4 which would be merged when ready. The rational is that the step by step migration could introduce some issues (even minor) and could cause multiple releases to have unstable (or annoying GUI glitch). Hope you'll agree with the approach. If so, we will try hard (I promise) to not change too much the Gtk code while it is being migrated to Gtk4 to avoid introducing more work and merge conflicts. |
|
Hello to everyone, no problem for me. As you might have recognized, I got less time the last few month :-(. Hopefully I got more time for migration in the end of the year. Sry for the delay. Feel free to take my code changes till here and bring them into the process again till I got more time. Good luck for everyone and thanks for all your work. |
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
This pr is connected to #15923, which has been closed and reopened here on a new branch.
Hello to everyone,
this pr will migrate the first button-pressed and button-release to the new GtkGesture API. Please test if everything is working as before. I do not find any problem but I also might have missed something.
I will wait with all further migration to this event context, until this pr has been reviewed. This is because I want to be sure, that the way I implemented it is your preferred way and I don't need to do things twice. :-)
Just to let all of you know: I am coming from the cpp perspective. This might break some things in code structure in the way I prefer to implement it.
Looking forward to your reply.
Thanks in advance
Greetings